DOCSP-44862 Update aggregation code examples #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
approved these changes
Oct 31, 2024
stephmarie17
commented
Oct 31, 2024
| @@ -1,6 +1,7 @@ | |||
| use bson::{ doc, DateTime }; | |||
| use bson::{ doc, DateTime, Document }; | |||
There was a problem hiding this comment.
[note for tech reviewer] Are the all updates in this file also ok to backport for <3.0 versions or is there any difference to note?
There was a problem hiding this comment.
The actual call to aggregate is different pre-3.0 because the aggregate method used to accept a second parameter with options, but the removal of from_document would still apply
There was a problem hiding this comment.
Makes sense, ty!
isabelatkinson
approved these changes
Oct 31, 2024
| @@ -1,6 +1,7 @@ | |||
| use bson::{ doc, DateTime }; | |||
| use bson::{ doc, DateTime, Document }; | |||
There was a problem hiding this comment.
The actual call to aggregate is different pre-3.0 because the aggregate method used to accept a second parameter with options, but the removal of from_document would still apply
stephmarie17
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 179c64e)
stephmarie17
added a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 179c64e)
stephmarie17
added a commit
to stephmarie17/docs-rust
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 179c64e)
stephmarie17
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44862
Staging - https://deploy-preview-141--docs-rust.netlify.app/fundamentals/aggregation/
Self-Review Checklist